Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not escape links in sourcecode without [source] header: https://gi… #830

Merged
merged 1 commit into from
Nov 19, 2023

Conversation

opoudjis
Copy link
Contributor

…thub.com/metanorma/iso-10303-detached-docs/issues/239

Metanorma PR checklist

@opoudjis opoudjis self-assigned this Nov 19, 2023
@@ -1258,7 +1264,7 @@
</math>
<asciimath>n</asciimath>
</stem>
</dt><dt id="symbol-Xa">Xa</dt><dt id="symbol-x">x</dt><dt id="symbol-x_m_">x_m_</dt><dt id="symbol-x_1_">x_1_</dt><dt id="symbol-__x3b1_">α</dt>
</dt><dt id="symbol-Xa">Xa</dt><dt id="symbol-x">x</dt><dt id="symbol-x_m_">x_m_</dt><dt id="symbol-x_1_">x_1_</dt><dt id="symbol-_2d">2d</dt><dt id="symbol-__x3b1_">α</dt>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line is too long. [178/80]

@@ -3,6 +3,7 @@
require "fileutils"

RSpec.describe Metanorma::Standoc do
=begin
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not use block comments.

Copy link

codecov bot commented Nov 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f25f7d1) 98.03% compared to head (d3752d4) 96.57%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #830      +/-   ##
==========================================
- Coverage   98.03%   96.57%   -1.47%     
==========================================
  Files          63       64       +1     
  Lines        5244     5248       +4     
==========================================
- Hits         5141     5068      -73     
- Misses        103      180      +77     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@opoudjis opoudjis merged commit c851d1d into main Nov 19, 2023
19 of 20 checks passed
@opoudjis opoudjis deleted the fix/source_link branch November 19, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant