Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contributor metadata in metanorma extensions: https://github.com/meta… #850

Merged
merged 1 commit into from
Dec 28, 2023

Conversation

opoudjis
Copy link
Contributor

…norma/metanorma-nist/issues/277

Metanorma PR checklist

@opoudjis opoudjis self-assigned this Dec 28, 2023
* [[[iso123,merge(ISO 125, IETF(RFC 8341))]]], _Standard_
INPUT
output = <<~OUTPUT
#{BLANK_HDR}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use 2 spaces for indentation in a heredoc.

expect(xml.at("//xmlns:bibitem[@id = 'iso125']/@hidden")&.text).to eq "true"
expect(xml.at("//xmlns:bibitem[@id = 'iso126']/@hidden")&.text).to eq "true"
expect(xml.at("//xmlns:bibitem[@id = 'iso127']/@hidden")&.text).not_to eq "true"
expect(xml.at("//xmlns:bibitem[@id = 'iso128']/@hidden")&.text).not_to eq "true"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line is too long. [86/80]

xml = Nokogiri::XML(Asciidoctor.convert(input, *OPTIONS))
expect(xml.at("//xmlns:bibitem[@id = 'iso125']/@hidden")&.text).to eq "true"
expect(xml.at("//xmlns:bibitem[@id = 'iso126']/@hidden")&.text).to eq "true"
expect(xml.at("//xmlns:bibitem[@id = 'iso127']/@hidden")&.text).not_to eq "true"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line is too long. [86/80]

INPUT
xml = Nokogiri::XML(Asciidoctor.convert(input, *OPTIONS))
expect(xml.at("//xmlns:bibitem[@id = 'iso125']/@hidden")&.text).to eq "true"
expect(xml.at("//xmlns:bibitem[@id = 'iso126']/@hidden")&.text).to eq "true"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line is too long. [82/80]

* [[[iso128,hidden=false,ABC]]] _Standard_
INPUT
xml = Nokogiri::XML(Asciidoctor.convert(input, *OPTIONS))
expect(xml.at("//xmlns:bibitem[@id = 'iso125']/@hidden")&.text).to eq "true"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line is too long. [82/80]

.to eq("true")
expect(doc.at("//xmlns:bibitem[@id = 'iso125']/@suppress_identifier")&.text)
.to eq("true")
expect(doc.at("//xmlns:bibitem[@id = 'iso126']/@suppress_identifier")&.text)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line is too long. [82/80]

.to eq("true")
expect(doc.at("//xmlns:bibitem[@id = 'iso124']/@suppress_identifier")&.text)
.to eq("true")
expect(doc.at("//xmlns:bibitem[@id = 'iso125']/@suppress_identifier")&.text)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line is too long. [82/80]

doc = Nokogiri::XML(Asciidoctor.convert(input, *OPTIONS))
expect(doc.at("//xmlns:bibitem[@id = 'iso123']/@suppress_identifier")&.text)
.to eq("true")
expect(doc.at("//xmlns:bibitem[@id = 'iso124']/@suppress_identifier")&.text)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line is too long. [82/80]

* [[[iso126,dropid=true,ISO 124:2014]]] _Standard_
INPUT
doc = Nokogiri::XML(Asciidoctor.convert(input, *OPTIONS))
expect(doc.at("//xmlns:bibitem[@id = 'iso123']/@suppress_identifier")&.text)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line is too long. [82/80]

* [[[iso123,BIPM CIPM RES 1 (1879)]]] _Standard_
INPUT
output = <<~OUTPUT
#{BLANK_HDR}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use 2 spaces for indentation in a heredoc.

Copy link

codecov bot commented Dec 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7eff1b6) 98.20% compared to head (5a502dc) 98.23%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #850      +/-   ##
==========================================
+ Coverage   98.20%   98.23%   +0.02%     
==========================================
  Files          66       66              
  Lines        5297     5371      +74     
==========================================
+ Hits         5202     5276      +74     
  Misses         95       95              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@opoudjis opoudjis merged commit 1639fd7 into main Dec 28, 2023
21 checks passed
@opoudjis opoudjis deleted the features/metanorma-extension-contributors branch December 28, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant