-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
contributor metadata in metanorma extensions: https://github.com/meta… #850
Conversation
* [[[iso123,merge(ISO 125, IETF(RFC 8341))]]], _Standard_ | ||
INPUT | ||
output = <<~OUTPUT | ||
#{BLANK_HDR} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use 2 spaces for indentation in a heredoc.
expect(xml.at("//xmlns:bibitem[@id = 'iso125']/@hidden")&.text).to eq "true" | ||
expect(xml.at("//xmlns:bibitem[@id = 'iso126']/@hidden")&.text).to eq "true" | ||
expect(xml.at("//xmlns:bibitem[@id = 'iso127']/@hidden")&.text).not_to eq "true" | ||
expect(xml.at("//xmlns:bibitem[@id = 'iso128']/@hidden")&.text).not_to eq "true" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line is too long. [86/80]
xml = Nokogiri::XML(Asciidoctor.convert(input, *OPTIONS)) | ||
expect(xml.at("//xmlns:bibitem[@id = 'iso125']/@hidden")&.text).to eq "true" | ||
expect(xml.at("//xmlns:bibitem[@id = 'iso126']/@hidden")&.text).to eq "true" | ||
expect(xml.at("//xmlns:bibitem[@id = 'iso127']/@hidden")&.text).not_to eq "true" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line is too long. [86/80]
INPUT | ||
xml = Nokogiri::XML(Asciidoctor.convert(input, *OPTIONS)) | ||
expect(xml.at("//xmlns:bibitem[@id = 'iso125']/@hidden")&.text).to eq "true" | ||
expect(xml.at("//xmlns:bibitem[@id = 'iso126']/@hidden")&.text).to eq "true" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line is too long. [82/80]
* [[[iso128,hidden=false,ABC]]] _Standard_ | ||
INPUT | ||
xml = Nokogiri::XML(Asciidoctor.convert(input, *OPTIONS)) | ||
expect(xml.at("//xmlns:bibitem[@id = 'iso125']/@hidden")&.text).to eq "true" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line is too long. [82/80]
.to eq("true") | ||
expect(doc.at("//xmlns:bibitem[@id = 'iso125']/@suppress_identifier")&.text) | ||
.to eq("true") | ||
expect(doc.at("//xmlns:bibitem[@id = 'iso126']/@suppress_identifier")&.text) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line is too long. [82/80]
.to eq("true") | ||
expect(doc.at("//xmlns:bibitem[@id = 'iso124']/@suppress_identifier")&.text) | ||
.to eq("true") | ||
expect(doc.at("//xmlns:bibitem[@id = 'iso125']/@suppress_identifier")&.text) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line is too long. [82/80]
doc = Nokogiri::XML(Asciidoctor.convert(input, *OPTIONS)) | ||
expect(doc.at("//xmlns:bibitem[@id = 'iso123']/@suppress_identifier")&.text) | ||
.to eq("true") | ||
expect(doc.at("//xmlns:bibitem[@id = 'iso124']/@suppress_identifier")&.text) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line is too long. [82/80]
* [[[iso126,dropid=true,ISO 124:2014]]] _Standard_ | ||
INPUT | ||
doc = Nokogiri::XML(Asciidoctor.convert(input, *OPTIONS)) | ||
expect(doc.at("//xmlns:bibitem[@id = 'iso123']/@suppress_identifier")&.text) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line is too long. [82/80]
* [[[iso123,BIPM CIPM RES 1 (1879)]]] _Standard_ | ||
INPUT | ||
output = <<~OUTPUT | ||
#{BLANK_HDR} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use 2 spaces for indentation in a heredoc.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #850 +/- ##
==========================================
+ Coverage 98.20% 98.23% +0.02%
==========================================
Files 66 66
Lines 5297 5371 +74
==========================================
+ Hits 5202 5276 +74
Misses 95 95 ☔ View full report in Codecov by Sentry. |
…norma/metanorma-nist/issues/277
Metanorma PR checklist