Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/preprocess include prerun #874

Merged
merged 6 commits into from
Mar 4, 2024
Merged

Conversation

opoudjis
Copy link
Contributor

@opoudjis opoudjis commented Mar 4, 2024

Metanorma PR checklist

@opoudjis opoudjis self-assigned this Mar 4, 2024
.to be_equivalent_to Metanorma::Standoc::Converter.new(nil,
nil).schema_version
.to be_equivalent_to Metanorma::Standoc::Converter.new(nil, nil)
.schema_version
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use 2 (not 0) spaces for indenting an expression spanning multiple lines.

@@ -719,7 +752,7 @@
rescue SystemExit, RuntimeError
end
expect(File.read("test.err.html"))
.to include 'The IEV document 60050-03 that has been cited does not exist'
.to include "The IEV document 60050-03 that has been cited does not exist"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line is too long. [82/80]

rescue SystemExit, RuntimeError
end
expect(File.read("test.err.html"))
.to include "Unresolved directive in <​stdin> - include::​spec/​subdir/a4.​adoc[]"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line is too long. [94/80]

@@ -2,6 +2,16 @@
require "fileutils"

RSpec.describe Metanorma::Standoc do
=begin
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not use block comments.

@opoudjis opoudjis merged commit ac87b46 into main Mar 4, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant