Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register extension Metanorma::Plugin::Lutaml::LutamlEaDiagramBlockMacro #904

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

kwkwan
Copy link
Contributor

@kwkwan kwkwan commented Aug 2, 2024

Metanorma PR checklist

@kwkwan kwkwan linked an issue Aug 2, 2024 that may be closed by this pull request
Copy link

@hound hound bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` paramete...
Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` parameter (in .rubocop.yml).
Supported versions: 2.4, 2.5, 2.6, 2.7, 3.0

@kwkwan
Copy link
Contributor Author

kwkwan commented Aug 2, 2024

Refer to metanorma/metanorma-plugin-lutaml#128, LutamlEaDiagramBlockMacro is needed to be registered in metanorma-standoc.

@kwkwan
Copy link
Contributor Author

kwkwan commented Aug 2, 2024

Do not merge this PR until metanorma-plugin-lutaml has been released.

@opoudjis
Copy link
Contributor

opoudjis commented Aug 5, 2024

metanorma-plugin-lutaml not release, so this is not making this release.

@kwkwan kwkwan force-pushed the reg-ext-lutaml-ea-diagram branch from 5387110 to a8ec84c Compare August 16, 2024 03:56
Copy link

@hound hound bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` paramete...
Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` parameter (in .rubocop.yml).
Supported versions: 2.4, 2.5, 2.6, 2.7, 3.0

@ronaldtse
Copy link
Contributor

Gem is released. @opoudjis please merge.

@opoudjis opoudjis merged commit 2b7281b into main Aug 16, 2024
19 of 20 checks passed
@opoudjis opoudjis deleted the reg-ext-lutaml-ea-diagram branch August 16, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Register extension Metanorma::Plugin::Lutaml::LutamlEaDiagramBlockMacro
3 participants