remove AsciiMath2UnitsML dependency: https://github.com/metanorma/met… #950
Conversation
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` paramete...
Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` parameter (in .rubocop.yml). Supported versions: 2.4, 2.5, 2.6, 2.7, 3.0
|
This is currently blocking Suma processing because it's not merged. Please help prioritize. |
| @@ -31,7 +31,7 @@ Gem::Specification.new do |spec| | |||
| spec.add_dependency "addressable", "~> 2.8.0" | |||
| spec.add_dependency "asciidoctor", "~> 2.0.0" | |||
| spec.add_dependency "crass", "~> 1.0.0" | |||
| spec.add_dependency "iev", "~> 0.3.0" | |||
| spec.add_dependency "iev", ">= 0.3.4" | |||
There was a problem hiding this comment.
You can keep this as ~> 0.3.4 which means larger or equal to 0.3.4 but not above 0.3.x.
|
Hi @opoudjis Could you please merge this PR when it is ready? Thank you. |
|
I've run out of time because of limited availability, so I will hotfix iev gem instead. |
No, I goddamn will not. I have spent 20 mins already trying to undo Hassan's reintroduction of IEV everywhere replacing Iev, I have limited time to waste like this, so I am going to just put IEV into standoc @HassanAkbar . You have disrupted downstream code in glossarist/iev@2d783f7 in March, by changing module names. You MUST NOT DO THIS without checking who is using that code. |
|
Now pending glossarist/iev#36 |
Apologies for the disruption here. Btw I didn't do this. This was already done in iev-data. I just extracted iev-data into iev after Ronald's approval in this here. @opoudjis If you need any support with the release, let me know I can try to support you here. |
…anorma-standoc/issues/947
Metanorma PR checklist