Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(URGENT: PDF) Missing Index page number in TOC and bad rendering of Index #257

Closed
ronaldtse opened this issue Dec 10, 2024 · 7 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@ronaldtse
Copy link
Contributor

ronaldtse commented Dec 10, 2024

Screenshot 2024-12-10 at 12 33 28 PM

And clicking on the TOC entry of the Index brings me back to the top:
Screenshot 2024-12-10 at 12 33 43 PM

The index is actually placed at the end but the rendering is also strange.

Screenshot 2024-12-10 at 12 34 22 PM
@ronaldtse ronaldtse added the bug Something isn't working label Dec 10, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in Metanorma Dec 10, 2024
@ronaldtse ronaldtse changed the title (URGENT: PDF) Missing Index page number in TOC (URGENT: PDF) Missing Index page number in TOC and bad rendering of Index Dec 10, 2024
@ronaldtse ronaldtse moved this from 🆕 New to 🌋 Urgent in Metanorma Dec 10, 2024
Intelligent2013 added a commit to metanorma/mn-native-pdf that referenced this issue Dec 10, 2024
@Intelligent2013
Copy link
Contributor

Fixed:
image

image

@Intelligent2013 Intelligent2013 moved this from 🌋 Urgent to ✅ Done in Metanorma Dec 10, 2024
@ReesePlews
Copy link
Contributor

thank you for the quick work @Intelligent2013! we will check this.

@ronaldtse
Copy link
Contributor Author

Thank you @Intelligent2013 !

@ReesePlews
Copy link
Contributor

hello @Intelligent2013 are these in the main branch or do we need to wait until the next release to confirm these revisions?

@Intelligent2013
Copy link
Contributor

hello @Intelligent2013 are these in the main branch or do we need to wait until the next release to confirm these revisions?

@ReesePlews the update made in metanorma-plateau gem. You need to wait until the next release if you use the docker based solution to generate the PDF. Or you can add the line

gem "metanorma-plateau", git: "https://github.com/metanorma/metanorma-plateau", branch: "main"

into Gemfile and then run:

bundle update
bundle exec metanorma sources/002-v4/document.adoc

@ReesePlews
Copy link
Contributor

hello @Intelligent2013 thank you for the information. we have been using metanorma locally to verify the updates to the branches before we issue the PR and request the merge to main on github. (sorry if my terminology is incorrect here).

my current Gemfile looks like this:

source "https://rubygems.org"

gem "metanorma-cli"

# WARNING: only for developers
# gem "metanorma-plateau", git: "https://github.com/metanorma/metanorma-plateau"
# gem "metanorma-iso", git: "https://github.com/metanorma/metanorma-iso"
# gem "isodoc", git: "https://github.com/metanorma/isodoc"
# gem "sassc"
# gem "debug"
# gem "metanorma-plateau", path: "~/src/mn/metanorma-plateau"

# gem "metanorma-plugin-lutaml", git: "https://github.com/metanorma/metanorma-plugin-lutaml"
# gem "metanorma-standoc", git: "https://github.com/metanorma/metanorma-standoc"
# gem "lutaml", git: "https://github.com/lutaml/lutaml"

# for local development
# gem "metanorma-plugin-lutaml", path: "~/src/metanorma/metanorma-plugin-lutaml"
# gem "metanorma-standoc", path: "~/src/metanorma/metanorma-standoc"
# gem "lutaml", path: "~/src/lutaml/lutaml"

i will modify it as you have described and see if my results are different. i will report back. thank you.

@Intelligent2013
Copy link
Contributor

my current Gemfile looks like this:

@ReesePlews you can just uncomment the line (remove # at start) :

gem "metanorma-plateau", git: "https://github.com/metanorma/metanorma-plateau"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

3 participants