Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Core Candy Machine with hidden settings guide #306

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Added Core Candy Machine with hidden settings guide #306

wants to merge 7 commits into from

Conversation

ASCorreia
Copy link

@ASCorreia ASCorreia commented Jan 11, 2025 •
edited
Loading

@vercel Vercel
Copy link

vercel bot commented Jan 11, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
developer-hub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 26, 2025 5:26pm

tonyboylehub
tonyboylehub requested changes Jan 11, 2025
View reviewed changes
Copy link
Collaborator

@tonyboylehub tonyboylehub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this Andre. Great first guide here, reads nice.

Just some small nits and a couple of comments that will have to be dicussed in slack/a meeting as probably to large a scope for github comments.

src/pages/core-candy-machine/guides/create-a-core-candy-machine-with-hidden-settings.md Outdated Show resolved Hide resolved
src/pages/core-candy-machine/guides/create-a-core-candy-machine-with-hidden-settings.md Outdated Show resolved Hide resolved
src/pages/core-candy-machine/guides/create-a-core-candy-machine-with-hidden-settings.md Outdated Show resolved Hide resolved
src/pages/core-candy-machine/guides/create-a-core-candy-machine-with-hidden-settings.md Outdated Show resolved Hide resolved
src/pages/core-candy-machine/guides/create-a-core-candy-machine-with-hidden-settings.md Show resolved Hide resolved
src/pages/core-candy-machine/guides/create-a-core-candy-machine-with-hidden-settings.md Outdated Show resolved Hide resolved
src/pages/core-candy-machine/guides/create-a-core-candy-machine-with-hidden-settings.md Show resolved Hide resolved
src/pages/core-candy-machine/guides/create-a-core-candy-machine-with-hidden-settings.md Outdated Show resolved Hide resolved
src/pages/core-candy-machine/guides/create-a-core-candy-machine-with-hidden-settings.md Outdated Show resolved Hide resolved
@ASCorreia
Update create-a-core-candy-machine-with-hidden-settings.md
c901348 
Reworked according to review comments
@tonyboylehub
Copy link
Collaborator

image
Also as a nit everything so far comes under a single Setting Up Umi heading. We should adjust these inside umi heading to be 1 level higher.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyboylehub tonyboylehub tonyboylehub requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ASCorreia @tonyboylehub