Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ports)!: streamlining and python support #14

Merged
merged 19 commits into from
Dec 21, 2023

Conversation

Yohe-Am
Copy link
Contributor

@Yohe-Am Yohe-Am commented Dec 15, 2023

Describe your change

  • Simplify port interface, encapsulate globals
  • Working directories for python/rust support
    • Working directories were found unnecessary
    • Python support
    • Rust support
  • Port runtime dependencies

Motivation and context

These features appear necessary for good support of the python & rust toolchains. The concept of cache/share/working dirs seems like a good fit for package/environment managers.

Migration notes

  • ghjk.ts scripts will need to use the install function from ghjk/mod.ts to add port installs. No more global aware function provided by ports
  • Port impls are expected to rewrite large chunks.

Checklist

  • The change come with new or modified tests
  • Hard-to-understand functions have explanatory comments
  • End-user documentation is updated to reflect the change

@Yohe-Am Yohe-Am changed the base branch from main to refactor/ci December 15, 2023 03:36
Base automatically changed from refactor/ci to main December 15, 2023 12:18
@Yohe-Am Yohe-Am force-pushed the refactor/ports-refactor-2 branch from 6040bb3 to 6a9a4af Compare December 15, 2023 12:29
@Yohe-Am Yohe-Am changed the title refactor(ports): streamlining and working dirs refactor(ports): streamlining ~~and working dirs~~ python support Dec 20, 2023
@Yohe-Am Yohe-Am changed the title refactor(ports): streamlining ~~and working dirs~~ python support refactor(ports): streamlining and ~~working dirs~~ python support Dec 20, 2023
@Yohe-Am Yohe-Am changed the title refactor(ports): streamlining and ~~working dirs~~ python support refactor(ports)!: streamlining and ~~working dirs~~ python support Dec 20, 2023
@Yohe-Am Yohe-Am marked this pull request as ready for review December 20, 2023 02:54
@Yohe-Am
Copy link
Contributor Author

Yohe-Am commented Dec 20, 2023

@zifeo Even the reduced scope of our python support required some...ridiculously hacky and fragile code but it's working now. The main reason for this difficulty due to how python sys vars are populated and the virtual environment creation and installation clashing with the isolation scheme in ghjk today. Some of the awkward python APIs aren't much help either. Will want to test these with more kinds of pip packages but it's worked with what I threw at it so far (poetry, pre-commit...).

Edit: might be be better you review this after I add comments on some of the sync code. (I'll do so ASAP)

@Yohe-Am Yohe-Am changed the title refactor(ports)!: streamlining and ~~working dirs~~ python support refactor(ports)!: streamlining and python support Dec 20, 2023
@Yohe-Am Yohe-Am force-pushed the refactor/ports-refactor-2 branch from 50a5223 to 18a45fc Compare December 20, 2023 15:48
@Yohe-Am Yohe-Am requested a review from zifeo December 20, 2023 15:59
@Yohe-Am Yohe-Am mentioned this pull request Dec 20, 2023
@Yohe-Am Yohe-Am linked an issue Dec 20, 2023 that may be closed by this pull request
This was unlinked from issues Dec 21, 2023
@Natoandro Natoandro merged commit cdaffea into main Dec 21, 2023
6 checks passed
@Natoandro Natoandro deleted the refactor/ports-refactor-2 branch December 21, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Good python support
3 participants