-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lsp): simple diagnostics #496
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yohe-Am
reviewed
Nov 28, 2023
Yohe-Am
reviewed
Nov 28, 2023
# Conflicts: # Cargo.lock
64a6925
to
6f21613
Compare
7c3f61d
to
7dd9d66
Compare
bae6ad0
to
6d6f8e4
Compare
6d6f8e4
to
12c9812
Compare
# Conflicts: # ghjk.deno.lock # ghjk.lock
@Natoandro I think what's happening here is that the |
Yohe-Am
approved these changes
Jan 10, 2024
Yohe-Am
approved these changes
Jan 10, 2024
Ah, so it doesn't let the original author approve a PR even though a separate author pushed the most recent changes. |
michael-0acf4
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change
Adds a simple LSP implementation for diagnostics.
Motivation and context
Better DX, catch potential errors while editing the typegraph module.
Migration notes
Checklist