feat: Artifact removal

[Natoandro]

• Add GC: remove artifacts when unreferenced by any deployed typegraph
• Improve resource management: use AsyncDisposable and AsyncDisposableStack
• Improve testability (for parallel testing): always read the tmpDir config from the Typegate object

Motivation and context

MET-433

Migration notes

N/A

Checklist

• The change come with new or modified tests
• Hard-to-understand functions have explanatory comments
• End-user documentation is updated to reflect the change

Summary by CodeRabbit

• New Features

  • Enhanced search functionality with the addition of a new search bar.
  • Introduced new test configurations to improve script execution.
  • Updated artifact storage documentation to clarify management processes.
  • Added new extensions to support improved code commenting.

• Bug Fixes

  • Removed outdated Deno import mapping settings to streamline development environment setup.

• Documentation

  • Expanded documentation on artifact tracking and management, including reference counting and garbage collection mechanisms.

• Refactor

  • Implemented interface changes in QueryEngine for better async disposal management.
  • Code restructuring in artifact management for enhanced performance and maintainability.

• Chores

  • Adjusted settings and configurations in the development environment to align with current best practices.

• Tests

  • Introduced new test cases for artifact upload and management functionalities.

[coderabbitai]

Actionable comments posted: 4

Out of diff range and nitpick comments (1)

typegate/tests/runtimes/deno/deno_partial.py (1)

8-22: Ensure consistent use of decorators and function definitions.

The @typegraph() decorator is used here, but it's not clear if it's necessary or correctly applied as there's no direct indication of its purpose from the provided code. It would be beneficial to add a comment explaining its use or to verify its necessity.

[Yohe-Am]

The "New Features" section that the LLM added to your PR description seems to be full of hallucinations.

[coderabbitai]

Actionable comments posted: 10

[destifo]

Good Stuff!!

[michael-0acf4]

Looking good so far!

[coderabbitai]

Actionable comments posted: 3

Out of diff range and nitpick comments (3)

typegate/tests/utils/test.ts (3)

16-16: Consider using a more specific import path for AsyncDisposableStack to avoid potential conflicts or issues with module resolution.

---

[!TIP]
Codebase Verification

The output from the executed script shows the implementation of the asyncDispose method in the TypegateManager class, which is located in the typegate/tests/utils/test.ts file. The method uses Promise.all to asynchronously dispose of all typegates managed by the TypegateManager. However, there is no explicit error handling mechanism, such as a try-catch block, to manage potential rejections from the asyncDispose calls of individual typegates.

Given this, the review comment suggesting the need for proper error handling in the asyncDispose method is valid. The current implementation could lead to unhandled promise rejections if any of the asyncDispose calls fail.

Conclusion

The review comment is correct in pointing out the absence of error handling in the asyncDispose method of the TypegateManager class. It would be beneficial to add a try-catch block around the Promise.all call to handle possible rejections appropriately.

• File: typegate/tests/utils/test.ts
• Method: async [Symbol.asyncDispose]()
• Suggestion: Implement error handling to manage potential rejections from the asyncDispose calls.

Analysis chain

Line range hint 40-56: Ensure proper error handling in the asyncDispose method to manage potential rejections from the asyncDispose calls.

Scripts Executed

The following scripts were executed for the analysis:

---

Script:

#!/bin/bash
# Description: Verify proper error handling in `asyncDispose` method of `TypegateManager`.

# Test: Search for error handling patterns in `asyncDispose` method. Expect: Catch blocks or error handling mechanisms.
rg --type ts 'asyncDispose' --context 5

Length of output: 16823

---

Line range hint 60-71: The implementation of asyncDispose in ServeResult should ensure that the server is properly shut down. Consider adding error handling for the shutdown method.

-            await server.shutdown();
+            try {
+                await server.shutdown();
+            } catch (error) {
+                console.error('Failed to shutdown server:', error);
+            }

Done!

[coderabbitai]

Actionable comments posted: 4

[codecov]

Codecov Report

Attention: Patch coverage is 83.66412% with 107 lines in your changes are missing coverage. Please review.

Project coverage is 73.85%. Comparing base (0cdd241) to head (6c7fd3c).

Files	Patch %	Lines
typegate/src/typegate/artifacts/local.ts	76.33%	31 Missing ⚠️
typegate/src/typegate/artifacts/mod.ts	84.07%	18 Missing ⚠️
typegate/src/typegate/artifacts/shared.ts	88.88%	18 Missing ⚠️
typegate/src/engine/query_engine.ts	71.42%	10 Missing ⚠️
typegate/src/typegate/mod.ts	91.52%	5 Missing ⚠️
typegate/src/utils.ts	50.00%	4 Missing ⚠️
typegate/src/runtimes/http.ts	0.00%	3 Missing ⚠️
typegate/src/runtimes/typegate.ts	25.00%	3 Missing ⚠️
typegate/src/typegraph/versions.ts	50.00%	3 Missing ⚠️
typegate/tests/utils/s3.ts	76.92%	3 Missing ⚠️
... and 8 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #668      +/-   ##
==========================================
- Coverage   73.95%   73.85%   -0.10%     
==========================================
  Files         121      120       -1     
  Lines       13555    13776     +221     
  Branches     1383     1393      +10     
==========================================
+ Hits        10024    10174     +150     
- Misses       3507     3576      +69     
- Partials       24       26       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.