Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump deno to 1.43.6 #737

Merged
merged 7 commits into from
Jun 3, 2024
Merged

chore: bump deno to 1.43.6 #737

merged 7 commits into from
Jun 3, 2024

Conversation

Yohe-Am
Copy link
Contributor

@Yohe-Am Yohe-Am commented May 27, 2024

Update deno to 1.43.6 and make requisite changes.

Required because of dep conflicts with latest lade-sdk.

Migration notes

  • The change comes with new or modified tests
  • Hard-to-understand functions have explanatory comments
  • End-user documentation is updated to reflect the change

Copy link
Contributor Author

@Yohe-Am Yohe-Am left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, so this PR exhibits a bug I can't seem to get the bottom of. The snapshot tests for typecheck_test.ts appear to be broken. You'll notice most of snapshots previously in the file were discarded. This wasn't intentional is precisely the issue. Some observations:

  • The subset of snapshots of that are kept is different on each --update run.
  • This means subsequent runs of the test will break because snapshots are missing.
  • The actual validation logic seems to be sound as far as I were able to printf all the value/error pairs.
  • There does seem to be a change introduced in this PR that required the snapshot updates. Functional or not, the generated code is different and it shouldn't be. Not sure what parts of v8/Deno are responsible.
  • I've tried updating to the latest version of the deno std.
  • It appears this is the only snapshot test suffering from this bug.

I spent most of today trying to fix this. Not sure where to go from here but I'll try to do more experiments tmw.

@Yohe-Am Yohe-Am requested review from Natoandro and michael-0acf4 and removed request for Natoandro May 28, 2024 00:00
@Yohe-Am Yohe-Am force-pushed the chore/bump-deno-to-1.43.6 branch from 4d7964f to ad81ad6 Compare May 28, 2024 00:00
@Yohe-Am Yohe-Am requested review from zifeo, Natoandro and destifo May 28, 2024 00:01
@zifeo zifeo force-pushed the chore/bump-deno-to-1.43.6 branch from ad81ad6 to 39b6ec3 Compare June 1, 2024 22:26
Copy link

codecov bot commented Jun 2, 2024

Codecov Report

Attention: Patch coverage is 90.32258% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 72.99%. Comparing base (544206c) to head (26edb5b).
Report is 2 commits behind head on main.

Files Patch % Lines
typegate/src/runtimes/wit_wire/mod.ts 50.00% 2 Missing ⚠️
typegate/src/sync/replicated_map.ts 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #737      +/-   ##
==========================================
- Coverage   73.00%   72.99%   -0.01%     
==========================================
  Files         117      117              
  Lines       14171    14181      +10     
  Branches     1415     1414       -1     
==========================================
+ Hits        10345    10351       +6     
- Misses       3799     3803       +4     
  Partials       27       27              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@zifeo zifeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Yohe-Am
Copy link
Contributor Author

Yohe-Am commented Jun 2, 2024

Huh, the python_sync_test no longer takes 10 minutes to run but something else is blowing up the test suite runtime. I'll disable the rust cache for now but this ought to be investigated next week.

Natoandro
Natoandro previously approved these changes Jun 2, 2024
@Yohe-Am Yohe-Am merged commit f2b7d82 into main Jun 3, 2024
12 checks passed
@Yohe-Am Yohe-Am deleted the chore/bump-deno-to-1.43.6 branch June 3, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants