-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump deno to 1.43.6 #737
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, so this PR exhibits a bug I can't seem to get the bottom of. The snapshot tests for typecheck_test.ts
appear to be broken. You'll notice most of snapshots previously in the file were discarded. This wasn't intentional is precisely the issue. Some observations:
- The subset of snapshots of that are kept is different on each
--update
run. - This means subsequent runs of the test will break because snapshots are missing.
- The actual validation logic seems to be sound as far as I were able to printf all the value/error pairs.
- There does seem to be a change introduced in this PR that required the snapshot updates. Functional or not, the generated code is different and it shouldn't be. Not sure what parts of v8/Deno are responsible.
- I've tried updating to the latest version of the deno std.
- It appears this is the only snapshot test suffering from this bug.
I spent most of today trying to fix this. Not sure where to go from here but I'll try to do more experiments tmw.
4d7964f
to
ad81ad6
Compare
ad81ad6
to
39b6ec3
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #737 +/- ##
==========================================
- Coverage 73.00% 72.99% -0.01%
==========================================
Files 117 117
Lines 14171 14181 +10
Branches 1415 1414 -1
==========================================
+ Hits 10345 10351 +6
- Misses 3799 3803 +4
Partials 27 27 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Huh, the |
Signed-off-by: Yohe-Am <[email protected]>
Update deno to 1.43.6 and make requisite changes.
Required because of dep conflicts with latest lade-sdk.
Migration notes