Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing typegraphs #755

Merged
merged 3 commits into from
Jun 22, 2024
Merged

fix: missing typegraphs #755

merged 3 commits into from
Jun 22, 2024

Conversation

zifeo
Copy link
Member

@zifeo zifeo commented Jun 15, 2024

  • fix the typegraphs that were incorrectly formatted
  • The change comes with new or modified tests
  • Hard-to-understand functions have explanatory comments
  • End-user documentation is updated to reflect the change

@zifeo zifeo requested a review from destifo June 15, 2024 14:14
@destifo
Copy link
Contributor

destifo commented Jun 15, 2024

So the missing typegraphs issue came from stderr of the ruff formatting command not being handled?

@zifeo
Copy link
Member Author

zifeo commented Jun 18, 2024

@destifo quite unsure yet, but at least we would have the debug logs for that now - more knowledge, better idea where the failure is :)

Copy link

codecov bot commented Jun 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.40%. Comparing base (fc6a7bc) to head (8c97a2e).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #755   +/-   ##
=======================================
  Coverage   73.40%   73.40%           
=======================================
  Files         115      115           
  Lines       14027    14027           
  Branches     1416     1416           
=======================================
  Hits        10297    10297           
  Misses       3704     3704           
  Partials       26       26           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@destifo destifo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zifeo zifeo merged commit 41a84cc into main Jun 22, 2024
12 checks passed
@zifeo zifeo deleted the missings branch June 22, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants