Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: better arg split logic for MCLI_LOADER #799

Merged
merged 6 commits into from
Jul 25, 2024
Merged

feat: better arg split logic for MCLI_LOADER #799

merged 6 commits into from
Jul 25, 2024

Conversation

j03-dev
Copy link
Contributor

@j03-dev j03-dev commented Jul 24, 2024

Migration notes

...

  • The change comes with new or modified tests
  • Hard-to-understand functions have explanatory comments
  • End-user documentation is updated to reflect the change

@j03-dev j03-dev requested a review from michael-0acf4 July 24, 2024 14:59
michael-0acf4
michael-0acf4 reviewed Jul 24, 2024
View reviewed changes
Copy link
Contributor

@michael-0acf4 michael-0acf4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far, just make sure you find all places where a naive .split(' ') is used on meta cli, the ones I provided was for reference.

@linear Linear
Copy link

linear bot commented Jul 24, 2024

MET-599 (cli) better arg split logic for MCLI_LOADER

@j03-dev j03-dev enabled auto-merge (squash) July 24, 2024 16:11
@j03-dev j03-dev requested a review from michael-0acf4 July 24, 2024 16:17
@codecov Codecov
Copy link

codecov bot commented Jul 24, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.91%. Comparing base (faed891) to head (1b82229).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #799   +/-   ##
=======================================
  Coverage   69.91%   69.91%           
=======================================
  Files         139      139           
  Lines       16181    16181           
  Branches     1475     1476    +1     
=======================================
  Hits        11313    11313           
  Misses       4843     4843           
  Partials       25       25

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

michael-0acf4
michael-0acf4 requested changes Jul 24, 2024
View reviewed changes
@michael-0acf4 michael-0acf4 disabled auto-merge July 24, 2024 18:48
@j03-dev j03-dev requested a review from michael-0acf4 July 25, 2024 06:55
@j03-dev j03-dev merged commit 25d5c24 into main Jul 25, 2024
11 checks passed
@j03-dev j03-dev deleted the feat/met-599-better-args-split-logic branch July 25, 2024 17:59
Yohe-Am added a commit that referenced this pull request Aug 7, 2024
@Yohe-Am
Squashed commit of the following:
c36e2f7 
commit 25d96a8
Author: Yohe-Am <[email protected]>
Date:   Wed Aug 7 07:21:33 2024 +0300

    refactor: PreparedArgs api

commit 278bc09
Author: Yohe-Am <[email protected]>
Date:   Wed Aug 7 03:10:16 2024 +0300

    test: alias tests

commit 8ff17ec
Author: Yohe-Am <[email protected]>
Date:   Fri Aug 2 08:46:56 2024 +0300

    fix: test

commit 62d534d
Merge: d1c532e 4c30067
Author: Yohe-Am <[email protected]>
Date:   Fri Aug 2 06:46:33 2024 +0300

    Merge branch 'main' into feat/MET-567/python-gen-client

commit d1c532e
Author: Yohe-Am <[email protected]>
Date:   Fri Aug 2 04:30:28 2024 +0300

    tests: client_py

commit 676bdb8
Author: Yohe-Am <[email protected]>
Date:   Fri Aug 2 03:58:03 2024 +0300

    tests: client_py

commit 4c30067
Author: Yohe-Am <[email protected]>
Date:   Thu Aug 1 11:36:14 2024 +0300

    chore: prepare 0.4.6 (#795)

    - Bump version to 0.4.6-0
    - Add sanity tests for published SDKs
    - Bump deno to 1.45.2
    - Bump rust to 1.79.0
    - Fix myriad of bugs

    #### Migration notes

    ...

    - [x] The change comes with new or modified tests
    - [ ] Hard-to-understand functions have explanatory comments
    - [ ] End-user documentation is updated to reflect the change

    <!-- This is an auto-generated comment: release notes by coderabbit.ai
    -->

    ## Summary by CodeRabbit

    - **New Features**
    - Introduced new logging capabilities in the `ConnectedEngine` with
    adjustable logging levels.
    - Implemented cleanup procedures in tests to enhance resource
    management.

    - **Bug Fixes**
    - Fixed import paths for permissions to ensure correct functionality in
    tests and applications.

    - **Version Updates**
    - Incremented version numbers across multiple projects and packages to
    reflect ongoing development and improvements.

    - **Documentation**
    - Added comments to clarify code behavior and potential future
    considerations in various modules.

    - **Refactor**
    - Optimized string handling in several functions and adjusted method
    signatures for improved clarity and efficiency.

    <!-- end of auto-generated comment: release notes by coderabbit.ai -->

commit f0ecfb5
Author: Yohe-Am <[email protected]>
Date:   Thu Aug 1 08:01:10 2024 +0300

    wip: wip

commit a48203a
Author: Yohe-Am <[email protected]>
Date:   Thu Aug 1 06:15:12 2024 +0300

    wip: wip

commit bfee2f2
Author: Yohe-Am <[email protected]>
Date:   Thu Aug 1 05:22:51 2024 +0300

    wip: wip

commit e57c322
Author: Yohe-Am <[email protected]>
Date:   Wed Jul 31 19:16:23 2024 +0300

    wip: wip

commit f55a3e7
Author: Yohe-Am <[email protected]>
Date:   Wed Jul 31 13:37:01 2024 +0300

    wip: wip

commit 25d5c24
Author: FITAHIANA Nomeniavo joe <[email protected]>
Date:   Thu Jul 25 20:59:22 2024 +0300

    feat:  better arg split logic for MCLI_LOADER (#799)

    <!--
    Pull requests are squashed and merged using:
    - their title as the commit message
    - their description as the commit body

    Having a good title and description is important for the users to get
    readable changelog.
    -->

    <!-- 1. Explain WHAT the change is about -->

    -

    <!-- 2. Explain WHY the change cannot be made simpler -->

    -

    <!-- 3. Explain HOW users should update their code -->

    #### Migration notes

    ...

    - [ ] The change comes with new or modified tests
    - [ ] Hard-to-understand functions have explanatory comments
    - [ ] End-user documentation is updated to reflect the change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-0acf4 michael-0acf4 michael-0acf4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@j03-dev @michael-0acf4