Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): Fix auto deployment #806

Merged
merged 7 commits into from
Aug 7, 2024
Merged

feat(cli): Fix auto deployment #806

merged 7 commits into from
Aug 7, 2024

Conversation

Natoandro
Copy link
Contributor

@Natoandro Natoandro commented Aug 5, 2024

  • Upgrade lade-sdk
  • Fix discovery
  • Remove obsolete dep: actix-web
  • lade-sdk uses the main branch, which now has the fix for the following issues:
    • dependency version conflict with deno: url is set at <2.5.0;
    • required ProjectID error for infisical: the project id is added explicitly on the command.

Migration notes

...

  • The change comes with new or modified tests
  • Hard-to-understand functions have explanatory comments
  • End-user documentation is updated to reflect the change

@Natoandro Natoandro marked this pull request as ready for review August 6, 2024 06:09
zifeo
zifeo previously approved these changes Aug 6, 2024
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.69%. Comparing base (843542e) to head (cc9ae6e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #806   +/-   ##
=======================================
  Coverage   69.69%   69.69%           
=======================================
  Files         142      142           
  Lines       16527    16526    -1     
  Branches     1477     1477           
=======================================
  Hits        11518    11518           
+ Misses       4984     4983    -1     
  Partials       25       25           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Natoandro Natoandro merged commit a1490e2 into main Aug 7, 2024
13 checks passed
@Natoandro Natoandro deleted the fix-deployment branch August 7, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants