Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add caching to Secrets struct to improve performance #813

Merged
merged 3 commits into from
Aug 23, 2024

Conversation

j03-dev
Copy link
Contributor

@j03-dev j03-dev commented Aug 14, 2024

Migration notes

  • The change comes with new or modified tests
  • Hard-to-understand functions have explanatory comments
  • End-user documentation is updated to reflect the change

@j03-dev j03-dev requested a review from Natoandro August 14, 2024 07:12
Copy link

linear bot commented Aug 14, 2024

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.90%. Comparing base (58d220f) to head (8871983).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #813      +/-   ##
==========================================
- Coverage   69.12%   68.90%   -0.23%     
==========================================
  Files         144      144              
  Lines       16673    16673              
  Branches     1478     1472       -6     
==========================================
- Hits        11526    11488      -38     
- Misses       5121     5159      +38     
  Partials       26       26              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@j03-dev j03-dev enabled auto-merge (squash) August 14, 2024 10:58
@j03-dev j03-dev disabled auto-merge August 14, 2024 10:58
@j03-dev j03-dev merged commit 2db4e13 into main Aug 23, 2024
11 checks passed
@j03-dev j03-dev deleted the feat/met-584-partial-secret-hydration branch August 23, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants