Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve name generation for prisma types #849

Merged
merged 14 commits into from
Sep 24, 2024
Merged

fix: improve name generation for prisma types #849

merged 14 commits into from
Sep 24, 2024

Conversation

Natoandro
Copy link
Contributor

Solve MET-657

Migration notes

...

  • The change comes with new or modified tests
  • Hard-to-understand functions have explanatory comments
  • End-user documentation is updated to reflect the change

@linear Linear
Copy link

linear bot commented Sep 18, 2024

MET-657 (sdk) improve generated titles for prisma types

@Natoandro Natoandro force-pushed the met-657-prisma-generated-type-names branch from 172914a to 6b9e63a Compare September 19, 2024 06:19
@Natoandro Natoandro marked this pull request as ready for review September 19, 2024 06:21
Yohe-Am
Yohe-Am previously approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@Yohe-Am Yohe-Am left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed, I'm actually using the snek case format for generated names in the other PR while the new names in this PR seem to be Pascal case. How should we proceed?

@Natoandro
Copy link
Contributor Author

Just noticed, I'm actually using the snek case format for generated names in the other PR while the new names in this PR seem to be Pascal case. How should we proceed?

I will switch to snake case....

michael-0acf4
michael-0acf4 previously approved these changes Sep 23, 2024
View reviewed changes
@codecov Codecov
Copy link

codecov bot commented Sep 24, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.04%. Comparing base (c56803c) to head (b2fd98f).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #849   +/-   ##
=======================================
  Coverage   77.04%   77.04%           
=======================================
  Files         147      147           
  Lines       17226    17226           
  Branches     1697     1697           
=======================================
  Hits        13271    13271           
  Misses       3936     3936           
  Partials       19       19

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Natoandro Natoandro merged commit 24eb721 into main Sep 24, 2024
12 checks passed
@Natoandro Natoandro deleted the met-657-prisma-generated-type-names branch September 24, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-0acf4 michael-0acf4 michael-0acf4 approved these changes

@zifeo zifeo Awaiting requested review from zifeo

@j03-dev j03-dev Awaiting requested review from j03-dev

@luckasRanarison luckasRanarison Awaiting requested review from luckasRanarison

@Yohe-Am Yohe-Am Awaiting requested review from Yohe-Am

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Natoandro @michael-0acf4 @Yohe-Am