Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: python hostcall #860

Merged
merged 6 commits into from
Oct 10, 2024
Merged

feat: python hostcall #860

merged 6 commits into from
Oct 10, 2024

Conversation

j03-dev
Copy link
Contributor

@j03-dev j03-dev commented Sep 30, 2024

Dead lock on python worker

Migration notes

...

  • The change comes with new or modified tests
  • Hard-to-understand functions have explanatory comments
  • End-user documentation is updated to reflect the change

dead lock on python worker
Copy link

linear bot commented Sep 30, 2024

@j03-dev j03-dev changed the title python hostcall feat: python hostcall Sep 30, 2024
@j03-dev j03-dev requested a review from Natoandro September 30, 2024 17:40
tests/internal/py/logic.py Outdated Show resolved Hide resolved
tests/internal/py/logic.py Outdated Show resolved Hide resolved
tests/internal/py/logic.py Outdated Show resolved Hide resolved
@j03-dev j03-dev force-pushed the feat/met-658-python-hostcall branch from c1a3bcc to 302418e Compare October 9, 2024 08:27
@j03-dev j03-dev requested a review from Yohe-Am October 9, 2024 08:27
Yohe-Am
Yohe-Am previously approved these changes Oct 9, 2024
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 68.75000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 77.05%. Comparing base (bbef981) to head (7cd8c0b).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/typegate/src/runtimes/wit_wire/mod.ts 68.75% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #860      +/-   ##
==========================================
- Coverage   77.09%   77.05%   -0.04%     
==========================================
  Files         149      149              
  Lines       17849    17850       +1     
  Branches     1730     1732       +2     
==========================================
- Hits        13761    13755       -6     
- Misses       4065     4072       +7     
  Partials       23       23              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@j03-dev j03-dev requested a review from Yohe-Am October 9, 2024 21:00
@j03-dev j03-dev merged commit 9aefe89 into main Oct 10, 2024
11 of 14 checks passed
@j03-dev j03-dev deleted the feat/met-658-python-hostcall branch October 10, 2024 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants