-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: Checks/validation on t.either #868
Conversation
47cf656
to
df33b46
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #868 +/- ##
==========================================
- Coverage 77.09% 77.01% -0.08%
==========================================
Files 149 149
Lines 17849 17867 +18
Branches 1730 1737 +7
==========================================
Hits 13761 13761
- Misses 4065 4083 +18
Partials 23 23 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice 👍
A few comments...
tests/schema_validation/__snapshots__/type_comparison_test.ts.snap
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also add a validation for TypeNode::Union
which should fail validation if we have two variants with the same type.
The metagen test is failing... |
Emit a warning or an error when a variant is a subtype of another one.
Migration notes
BREAKING CHANGE: Previously valid typegraph might fail validation.
You will need to fix your types to add some consistency in
t.either
/t.union
types.