Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move injection data to t.func #871

Merged
merged 27 commits into from
Oct 22, 2024
Merged

Conversation

Natoandro
Copy link
Contributor

@Natoandro Natoandro commented Oct 12, 2024

  • MET-682
    • Move all injection data in ObjectTypeData (i.e. t.func)
  • MET-656
    • Translate reduce to injection specification on t.func
  • MET-94
  • MET-683
    • Move runtime-related configs to MaterializerData or RuntimeData
  • Misc.
    • Enable random ports for the typegate (when TG_PORT=0); this will work with meta dev with embedded typegate if you set the --gate option with port 0.

Migration notes

...

  • The change comes with new or modified tests
  • Hard-to-understand functions have explanatory comments
  • End-user documentation is updated to reflect the change

Copy link

linear bot commented Oct 12, 2024

Copy link
Contributor

@Yohe-Am Yohe-Am left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

tools/tasks/build.ts Outdated Show resolved Hide resolved
Yohe-Am
Yohe-Am previously approved these changes Oct 18, 2024
Copy link
Contributor

@Yohe-Am Yohe-Am left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

# Conflicts:
#	.ghjk/lock.json
#	.pre-commit-config.yaml
#	ghjk.ts
#	src/typegate/src/runtimes/substantial.ts
Copy link
Contributor

@michael-0acf4 michael-0acf4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a lot of changes! Good stuff.

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 82.09719% with 70 lines in your changes missing coverage. Please review.

Project coverage is 76.80%. Comparing base (8e24b01) to head (df53556).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/typegate/src/typegraph/utils.ts 47.22% 19 Missing ⚠️
src/typegate/src/engine/planner/args.ts 89.60% 13 Missing ⚠️
src/typegate/src/runtimes/typegraph.ts 84.93% 11 Missing ⚠️
src/typegate/src/runtimes/random.ts 82.05% 7 Missing ⚠️
src/typegate/src/engine/planner/mod.ts 28.57% 5 Missing ⚠️
src/typegate/src/engine/planner/policies.ts 25.00% 3 Missing ⚠️
src/typegate/src/config/types.ts 60.00% 2 Missing ⚠️
src/typegate/src/runtimes/substantial.ts 71.42% 2 Missing ⚠️
src/typegate/src/typegraph/mod.ts 92.00% 2 Missing ⚠️
src/typegate/src/runtimes/Runtime.ts 94.44% 0 Missing and 1 partial ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #871      +/-   ##
==========================================
- Coverage   77.20%   76.80%   -0.41%     
==========================================
  Files         149      149              
  Lines       18103    18221     +118     
  Branches     1756     1768      +12     
==========================================
+ Hits        13976    13994      +18     
- Misses       4104     4204     +100     
  Partials       23       23              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Natoandro Natoandro merged commit 54558c7 into main Oct 22, 2024
13 of 14 checks passed
@Natoandro Natoandro deleted the met-682-injection-in-tfunc-2 branch October 22, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants