Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): disable sccache when secrets not avail #874

Merged
merged 5 commits into from
Oct 16, 2024

Conversation

Yohe-Am
Copy link
Contributor

@Yohe-Am Yohe-Am commented Oct 15, 2024

  • Makes sccache optional so PRs from dependabot and forks can still run the test suite.
  • Increases sccache allotment to 50g.

@Yohe-Am Yohe-Am requested a review from zifeo October 15, 2024 05:19
@Yohe-Am
Copy link
Contributor Author

Yohe-Am commented Oct 15, 2024

Hmm, I wonder why the test suite is not triggering on this PR.

zifeo
zifeo previously approved these changes Oct 15, 2024
Signed-off-by: Yohe-Am <[email protected]>
Signed-off-by: Yohe-Am <[email protected]>
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.11%. Comparing base (bbef981) to head (a7a6b01).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #874      +/-   ##
==========================================
+ Coverage   77.09%   77.11%   +0.01%     
==========================================
  Files         149      149              
  Lines       17849    17843       -6     
  Branches     1730     1732       +2     
==========================================
- Hits        13761    13759       -2     
+ Misses       4065     4061       -4     
  Partials       23       23              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Natoandro Natoandro merged commit a3310f4 into main Oct 16, 2024
14 checks passed
@Natoandro Natoandro deleted the fix/make-sccache-optional branch October 16, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants