Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INIMap: Add User-Declared Copy Assignment Operator #28

Merged
merged 4 commits into from
Jan 11, 2024
Merged

INIMap: Add User-Declared Copy Assignment Operator #28

merged 4 commits into from
Jan 11, 2024

Conversation

MabelYT
Copy link
Contributor

@MabelYT MabelYT commented Jan 10, 2024

Hi,

I've Been Using Your Library For My DOS Utility Collection MabelDOS For Some Time Now, And I've Just Enabled Verbose Warnings Under G++ And It Gave A Few Warnings About Missing Explicit CAO Operators Being Deprecated.

I've Gone Ahead And Added One, So You Can Use -Wall And -Wextra Without Any Warnings Showing Up.

Thanks!

P.S: I've Bumped The Minor Version Number To Signify A Bug Fix.
P.P.S: All Read/Write Tests Pass With lest.

@MabelYT
Copy link
Contributor Author

MabelYT commented Jan 10, 2024

I Apologize For The Duplicated Readme Update Commits.

@metayeti
Copy link
Owner

Hey. Looks proper, I will most likely merge it in. Please give me a day or two and I'll look into it - thanks!

@MabelYT
Copy link
Contributor Author

MabelYT commented Jan 10, 2024

Just A Quick Follow-Up, You'll Need To Create A New Release To Bump The Version Number.

@metayeti metayeti merged commit 6176ffa into metayeti:master Jan 11, 2024
@metayeti
Copy link
Owner

Merged! Thanks!

nlgxzef added a commit to nlgxzef/mINI-Extra that referenced this pull request Feb 14, 2024
- Renamed the fork to mINI-Extra.
- Switched to std::filesystem::path.
- Ported the changes from v0.9.15 of the main branch:
-- `BUGFIX` Fixes G++ warnings and implements a copy assignment operator for mINI::INIMap. ([metayeti#28](metayeti#28))
-- Updated lest from v1.32.0 to v1.35.2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants