Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better support for HTML5 attributes #102

Merged
merged 18 commits into from
Sep 26, 2016
Merged

Better support for HTML5 attributes #102

Changes from 4 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
4b53551
Better support for HTML5 attributes
gcacars Sep 17, 2016
0532413
Correct sandbox value
gcacars Sep 17, 2016
7678bd7
Readability of spellcheck
gcacars Sep 17, 2016
9a48fd6
Removed tabs
gcacars Sep 17, 2016
9a124bc
Correction of elem.contentEditable
gcacars Sep 17, 2016
b54ea02
Indentation
gcacars Sep 18, 2016
0ab0370
Fixed Unexpected token
gcacars Sep 18, 2016
00e0c3e
Indentation+
gcacars Sep 18, 2016
44c09a4
Add Tests to better support for HTML5 attributes
gcacars Sep 18, 2016
e38017c
Fix JS HTML attribute names
gcacars Sep 18, 2016
2862bf5
Removed autocomplete property
gcacars Sep 18, 2016
c5b257e
Removed spellcheck property
gcacars Sep 18, 2016
c476a9e
Removed spellcheck test
gcacars Sep 18, 2016
f9316ed
Changed history do PR #102
gcacars Sep 18, 2016
caa4775
Pass a boolean value to BooleanHandler when IFrame
gcacars Sep 20, 2016
361febc
More tests for iframe mode sandbox
gcacars Sep 20, 2016
ce519fe
Merge branch 'master' into patch-1
gcacars Sep 26, 2016
d327d66
Flush Tracker changes
gcacars Sep 26, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions packages/blaze/attrs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,6 +296,29 @@ Blaze._makeAttributeHandler = function (elem, name, value) {
} else if ((elem.tagName === 'OPTION' && name === 'selected') ||
(elem.tagName === 'INPUT' && name === 'checked')) {
return new BooleanHandler(name, value);
} else if (name === 'autocomplete' || name === 'autofocus' || name === 'disabled' ||
name === 'hidden' || name === 'readonly' || name === 'required') {
return new BooleanHandler(name, value);
} else if (elem.tagName === 'FORM' && name === 'novalidate') {
return new BooleanHandler(name, value);
} else if (elem.tagName === 'IFRAME' && name === 'sandbox') {
return new BooleanHandler(name, value);
} else if (elem.tagName === 'IMG' && name === 'ismap') {
return new BooleanHandler(name, value);
} else if ((elem.tagName === 'INPUT' || elem.tagName === 'SELECT')
&& name === 'multiple') {
return new BooleanHandler(name, value);
} else if (elem.tagName === 'OL' && name === 'reversed') {
return new BooleanHandler(name, value);
} else if (elem.tagName === 'SCRIPT' && (name === 'async' || name === 'defer')) {
return new BooleanHandler(name, value);
} else if (elem.tagName === 'VIDEO' && (name === 'autoplay' ||
name === 'controls' || name === 'loop' || name === 'muted')) {
return new BooleanHandler(name, value);
} else if ((name === 'spellcheck' && elem.contentEditable === 'true') ||
(name === 'spellcheck' && elem.tagName === 'TEXTAREA') ||
(name === 'spellcheck' && elem.tagName === 'INPUT' && elem.type !== 'password')) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, maybe:

(name === 'spellcheck' && (elem.contentEditable === 'true' || elem.tagName === 'TEXTAREA' || (elem.tagName === 'INPUT' && elem.type !== 'password'))

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm... right, I understood now! contenteditable was wrong before. Changed.

return new BooleanHandler(name, value);
} else if ((elem.tagName === 'TEXTAREA' || elem.tagName === 'INPUT')
&& name === 'value') {
// internally, TEXTAREAs tracks their value in the 'value'
Expand Down