Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tests #317

Merged
merged 6 commits into from
Mar 18, 2021
Merged

Improve tests #317

merged 6 commits into from
Mar 18, 2021

Conversation

jankapunkt
Copy link
Collaborator

I plan to do some further contributions and found the local tests to be hard to setup. I wrapped them into the test-app project and updated the contribution documentation to make local testing easier.

@jankapunkt jankapunkt mentioned this pull request Feb 11, 2021
@filipenevola
Copy link
Collaborator

Hi @jankapunkt I would like to move this PR forward, what is missing here?

@jankapunkt
Copy link
Collaborator Author

From end it's good so far, the Checks are failing because of the CI is not updated. You should however be good to run the tests locally by following the contributions.md section on testing. I would try on a GitHub actions CI in a separate PR

@brucejo75
Copy link
Contributor

@filipenevola, are you going to accept and merge @jankapunkt changes? Looks like the checks will never succeed because they need these fixes to run?

@filipenevola
Copy link
Collaborator

@filipenevola, are you going to accept and merge @jankapunkt changes? Looks like the checks will never succeed because they need these fixes to run?

I'm working on this branch right now to try to have some testing running on CI. In any case I already ran it locally and the tests are all passing.

@filipenevola filipenevola changed the base branch from master to improve-tests March 18, 2021 18:02
@filipenevola filipenevola merged commit 910a78f into meteor:improve-tests Mar 18, 2021
@filipenevola filipenevola mentioned this pull request Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants