Add types to core #403
Merged
Add types to core #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [moment-timezone](https://github.com/moment/moment-timezone) from 0.5.34 to 0.5.37. - [Release notes](https://github.com/moment/moment-timezone/releases) - [Changelog](https://github.com/moment/moment-timezone/blob/develop/changelog.md) - [Commits](moment/moment-timezone@0.5.34...0.5.37) --- updated-dependencies: - dependency-name: moment-timezone dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
…nt-timezone-0.5.37 Bump moment-timezone from 0.5.34 to 0.5.37 in /site
Bumps [decode-uri-component](https://github.com/SamVerschueren/decode-uri-component) from 0.2.0 to 0.2.2. - [Release notes](https://github.com/SamVerschueren/decode-uri-component/releases) - [Commits](SamVerschueren/decode-uri-component@v0.2.0...v0.2.2) --- updated-dependencies: - dependency-name: decode-uri-component dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
…de-uri-component-0.2.2 Bump decode-uri-component from 0.2.0 to 0.2.2 in /site
|
I changed the target to release-2.6.2 I think we should publish this asap, right? |
|
Yes! give it a try. Create a new app and test if typedefs are in this folder.
|
|
It is possible to use types from local packages, so you can try it before publishing. |
zodern
reviewed
Jan 11, 2023
|
I tried but I was not successful trying locally, the steps that I've made are:
the packages.d.ts stood blank :/ |
|
How did you configure Meteor to find the blaze packages? I usually do it by adding the You can check if Meteor found the local blaze package by running |
|
I ran |
|
@jankapunkt @zodern I'm fine with merging this and releasing this asap. |
zodern
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to meteor/meteor#12428
and also closes #388
I could not test it in the test app but if we publish it we maybe can in a newly created app?