Update caching-html-compiler #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missing import, few `;` additions. Add .jshintrc for code help with ES6 transition.
jankapunkt
reviewed
Nov 28, 2023
| @@ -0,0 +1,4 @@ | |||
| { | |||
| "undef": true, | |||
There was a problem hiding this comment.
Do we want to drop jshint altogether?
There was a problem hiding this comment.
For some reason in my IDE it demands it when I open Blaze repo. Right now it doesn't look like there is anything setup, so we should either get some rules here or at least do this minimum setup for people.
There was a problem hiding this comment.
I think for now we are good with it but we should introduce a stable ESLINT soon
jankapunkt
approved these changes
Nov 28, 2023
jankapunkt
approved these changes
Dec 4, 2023
| @@ -0,0 +1,4 @@ | |||
| { | |||
| "undef": true, | |||
There was a problem hiding this comment.
I think for now we are good with it but we should introduce a stable ESLINT soon
This was referenced Dec 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
;