Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blaze._expandAttributes returns empty object, if null or … #458

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Blaze._expandAttributes returns empty object, if null or … #458

merged 1 commit into from
Feb 29, 2024

Conversation

jankapunkt
Copy link
Collaborator

@jankapunkt jankapunkt mentioned this pull request Jan 9, 2024
Closed
@jankapunkt
Copy link
Collaborator Author

@StorytellerCZ @Grubba27 we should merge this asap, since there are people with breaking builds due to #456

@radekmie
Copy link
Collaborator

Actually, I just checked and https://github.com/meteor/blaze/pull/460/files#diff-bf43372770fd37ca51fcb7ff881dee72730e4bb0a61e2a041c7ff61836c13aeaR107-R110 solves this issue as well as the async version of it (i.e., when the dynamic attribute return Promise.resolve(undefined) or similar). I suggest to merge #460 first and add only tests in this PR.

What do you think @jankapunkt?

@radekmie
Copy link
Collaborator

Ping @jankapunkt.

@jankapunkt
Copy link
Collaborator Author

@radekmie yes, let's merge #460 and once it's merged I will update this accordingly.

@Grubba27 Grubba27 mentioned this pull request Jan 25, 2024
Merged
@jankapunkt jankapunkt changed the base branch from master to async-dynamic-attributes January 26, 2024 10:05
jankapunkt
jankapunkt commented Jan 26, 2024
View reviewed changes
packages/blaze/view.js
{parentView: parentView})).visitAttributes(attrs);
return expanded || {};
};
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@radekmie this is the part that can be reset, because it's covered by your feature, right?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please double check it, but yes - it's covered in #460.

@Grubba27 Grubba27 mentioned this pull request Feb 29, 2024
Merged
@Grubba27 Grubba27 changed the base branch from async-dynamic-attributes to release-2.9 February 29, 2024 13:29
@Grubba27 Grubba27 merged commit dfb88d1 into release-2.9 Feb 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radekmie radekmie radekmie approved these changes

@StorytellerCZ StorytellerCZ Awaiting requested review from StorytellerCZ

@Grubba27 Grubba27 Awaiting requested review from Grubba27

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeError: Cannot convert undefined or null to object in waitForAllAttributesAndContinue
3 participants
@jankapunkt @radekmie @Grubba27