Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a callAsync method #92

Merged
merged 2 commits into from
Mar 13, 2023
Merged

Added a callAsync method #92

merged 2 commits into from
Mar 13, 2023

Conversation

cluelesscamel
Copy link
Contributor

A pull request for a callAsync method we have been using internally for a while now.
It should be noted that the callback on Meteor.applyAsync will probably disappear in time and this is only going to work until it does.

This implementation checks all of the boxes for our needs:

  • Will catch stub errors as promise rejections and keep the server from running the method if it does
  • Will correctly mark a method as no longer running when its promise has been returned to allow for chaining of multiple async methods
  • Will not log Exception while running simulation to the browser
  • Will not throw Access denied errors in the browser by using Meteor.applyAsync

@CLAassistant
Copy link

CLAassistant commented Feb 5, 2023

CLA assistant check
All committers have signed the CLA.

@StorytellerCZ
Copy link
Contributor

@Grubba27 I think this is ready to be merged.

@Grubba27
Copy link
Contributor

Sure! Are you able to make the release?

@Grubba27 Grubba27 merged commit 049efa8 into meteor:master Mar 13, 2023
@StorytellerCZ
Copy link
Contributor

@Grubba27 No, this is under the mdg namespace.

@Grubba27
Copy link
Contributor

done! published under the 1.3.0 namespace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants