fix($api-gitee-v5): get comments count from headers (#46)

meteorlxy · Sep 6, 2019 · b07d745 · b07d745
1 parent 394bf42
commit b07d745
Showing 1 changed file with 2 additions and 9 deletions.
diff --git a/packages/@vssue/api-gitee-v5/src/index.ts b/packages/@vssue/api-gitee-v5/src/index.ts
@@ -296,20 +296,13 @@ export default class GiteeV5 implements VssueAPI.Instance {
         Accept: ['application/vnd.gitee.html+json'],
       },
     }
-    const issueOptions: AxiosRequestConfig = { params: {} }
     if (accessToken) {
       options.params.access_token = accessToken
-      issueOptions.params.access_token = accessToken
     }
 
-    // total_count of comments is not available now, so we have to request issue to get the count
-    const [response, issueResponse] = await Promise.all([
-      this.$http.get(`repos/${this.owner}/${this.repo}/issues/${issueId}/comments`, options),
-      this.$http.get(`repos/${this.owner}/${this.repo}/issues/${issueId}`, issueOptions),
-    ])
+    const response = await this.$http.get(`repos/${this.owner}/${this.repo}/issues/${issueId}/comments`, options)
 
-    const count = Number(issueResponse.data.comments)
-    // const count = Number(response.headers['total_count'])
+    const count = Number(response.headers['total_count'])
 
     return {
       count: count,