Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MS SQL boolean column not updated correctly #981

Closed
thetechnician94 opened this issue Jul 19, 2023 · 2 comments
Closed

MS SQL boolean column not updated correctly #981

thetechnician94 opened this issue Jul 19, 2023 · 2 comments
Assignees
Labels

Comments

@thetechnician94
Copy link

When trying to update a bit column in MS SQL, values evaluate to 'true' which are not expected. Specifically 'false' will update the column to a 1. Only a 0 will actually update the column correctly.

That is in the function convertInputValue the return for boolean should be:

return filter_var($value, FILTER_VALIDATE_BOOLEAN) ? 1 : 0;

so that 'false' converts to 0 instead of 1

@mevdschee mevdschee self-assigned this Jul 20, 2023
@mevdschee mevdschee added the bug label Jul 20, 2023
@mevdschee
Copy link
Owner

Yes.. good find

mevdschee added a commit that referenced this issue Jul 20, 2023
@mevdschee
Copy link
Owner

Fixed in v2.14.22: Fix boolean parsing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants