Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support rendering 'Oblique' fonts #236

Merged
merged 3 commits into from
Jul 12, 2024
Merged

Conversation

Tontyna
Copy link
Contributor

@Tontyna Tontyna commented Jul 11, 2024

resolves #235

@meyfa meyfa self-requested a review July 11, 2024 09:52
Copy link
Owner

@meyfa meyfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me, thanks @Tontyna! Could you fix the indentation to make PHPCS happy?

@Tontyna
Copy link
Contributor Author

Tontyna commented Jul 11, 2024

of course, if only I knew the rules... Tried to guess.

src/Fonts/FontRegistry.php Outdated Show resolved Hide resolved
src/Fonts/FontRegistry.php Outdated Show resolved Hide resolved
src/Fonts/TrueTypeFontFile.php Outdated Show resolved Hide resolved
@meyfa meyfa changed the title render 'Oblique' fonts feat: Support rendering 'Oblique' fonts Jul 12, 2024
@meyfa meyfa self-requested a review July 12, 2024 10:12
@meyfa meyfa merged commit efb03d8 into meyfa:main Jul 12, 2024
7 checks passed
@meyfa
Copy link
Owner

meyfa commented Jul 12, 2024

Thank you again for reporting this bug & also fixing it! This is now released as v0.16.0.

@Tontyna Tontyna deleted the render-oblique branch July 18, 2024 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rendering 'italic' or 'oblique' text misses fonts with 'Oblique' subfamily
2 participants