Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PHP 8 #10

Merged
merged 4 commits into from
May 14, 2021
Merged

Add support for PHP 8 #10

merged 4 commits into from
May 14, 2021

Conversation

internalsystemerror
Copy link
Member

Q A
Documentation no
Bugfix no
BC Break no
New Feature yes
RFC no
QA no

Description

Closes #6 .

Gary Lockett added 4 commits May 11, 2021 23:06
Signed-off-by: Gary Lockett <[email protected]>
Signed-off-by: Gary Lockett <[email protected]>
Signed-off-by: Gary Lockett <[email protected]>
@Xerkus Xerkus added the Enhancement New feature or request label May 11, 2021
@Xerkus
Copy link
Member

Xerkus commented May 11, 2021

Pre-release semantics is 0.<major>.<minor> iirc, should we target 0.1.6 here?

@boesing
Copy link
Member

boesing commented May 12, 2021

I'd be fine with 1.0 as well as this package didn't received any changes for almost 2 years.
Would assume its stable tho.

@Xerkus Xerkus changed the base branch from 0.2.x to 1.0.x May 14, 2021 18:52
@Xerkus Xerkus added this to the 1.0.0 milestone May 14, 2021
@Xerkus
Copy link
Member

Xerkus commented May 14, 2021

@internalsystemerror FYI convention is to name the file .gitkeep with the dot at the beginning, to match .gitignore. it originates from the *nix convention where files and folders starting with dot are "hidden" files.

@Xerkus Xerkus merged commit d0397d1 into mezzio:1.0.x May 14, 2021
@internalsystemerror internalsystemerror deleted the feature/php8 branch May 14, 2021 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PHP 8.0 support
3 participants