Psalm integration #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ocramius
reviewed
Jun 25, 2022
Signed-off-by: John Morrison <[email protected]>
Also requires the phpunit plugin for Psalm as generating the baseline xml file throws an exception without it. Signed-off-by: John Morrison <[email protected]>
Signed-off-by: John Morrison <[email protected]>
Signed-off-by: John Morrison <[email protected]>
Replace deprecated 'totallyTyped' attribute with 'errorLevel'. Signed-off-by: John Morrison <[email protected]>
|
See CI failures: the generated baseline is missing most reported errors 🤔 |
Hi - I don't see these errors when running static-analysis locally. Do you want them suppressed by expanding the baseline in the following manner? |
|
No, they should just appear as "known issues" in the baseline 🤔 Check what CI did run here: possibly some differences between local setup and this? |
Signed-off-by: John Morrison <[email protected]>
Signed-off-by: John Morrison <[email protected]>
Ocramius
approved these changes
Jun 26, 2022
There was a problem hiding this comment.
Besides the duplication, this looks much better now, thanks @jslmorrison!
Remove duplicate block Signed-off-by: John Morrison <[email protected]>
Closed
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add vimeo/psalm integration.