Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement pulse #36

Merged
merged 5 commits into from
Apr 13, 2019
Merged

implement pulse #36

merged 5 commits into from
Apr 13, 2019

Conversation

egonelbre
Copy link
Contributor

-pulse 5s prints "." every 5 seconds

Fixes #10

@mfridman
Copy link
Owner

mfridman commented Apr 11, 2019

Thanks for submitting this. I'd like to think about this one..

Background:

We use this tparse tool in our CI pipeline (drone) to summarize a subset of our tests (500+). We also use the -dump flag to get everything from go test, the idea is we'd

  1. get a summary
  2. get the original lines of code below the summary

But, we recently switched to drone >1.0 and noticed that -dump adds minutes to the pipeline, likely because many lines are being printed at once..

So, the idea I was thinking is..

a mechanism that prints go test output (only when summary is at the bottom, default) as it's running instead of holding on to it..

and once EOF the tests, pkg summary, etc. will be printed.


this will solve the original problem a few users reported, where they weren't sure tparse was working or not.

so they could run something like tparse -all -follow and tparse would just print whatever is coming from go test ... and at the very end display summary

thoughts?

EDIT: on the flip side, maybe users don't want go test output at all, would would rather prefer a simple spinner or ........ to indicate it's working.

Maybe these two features could co-exist

@egonelbre
Copy link
Contributor Author

The main reason for this basic pulse is that Travis kills the tests if there is no output for 10min. I do agree some diagnostic output would be nice as well, but that's a much larger change.

main.go Show resolved Hide resolved
main.go Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
@mfridman mfridman merged commit 1e6a0f4 into mfridman:master Apr 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add -progress flag to provide feedback that tparse is processing input
2 participants