Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve markdown output formatting #75

Merged
merged 19 commits into from
Jul 5, 2022
Merged

Improve markdown output formatting #75

merged 19 commits into from
Jul 5, 2022

Conversation

mfridman
Copy link
Owner

@mfridman mfridman commented Jul 4, 2022

Partially addresses #71

This PR improves the raw markdown output

Revisit #71 (comment) for collapsable sections.

@mfridman
Copy link
Owner Author

mfridman commented Jul 4, 2022

Something that bugs me a bit is how much nested spacing the Go tool adds:

--- FAIL: Test (0.42s)

    --- FAIL: Test/test_01 (0.04s)

        --- FAIL: Test/test_01/sort (0.00s)

    cover_test.go:75: got cover: 60.8, want package "sort" cover: 10.8

What if we trimmed this by half?

Note, this does not modify the test/user output, only the --- Fail: output line

--- FAIL: Test (0.42s)
  --- FAIL: Test/test_01 (0.04s)
    --- FAIL: Test/test_01/sort (0.00s)

    cover_test.go:75: got cover: 60.8, want package "sort" cover: 10.8

@mfridman
Copy link
Owner Author

mfridman commented Jul 5, 2022

Okay, this is what a bunch of failures look like now in rendered in markdown:

This GitHub Action run, https://github.com/mfridman/tparse/actions/runs/2613571846

CleanShot 2022-07-04 at 23 25 45@2x


There is one annoyance remaining, the package header in CI on GitHub looks a bit off:

CleanShot 2022-07-04 at 23 27 17@2x

But, on local terminal it looks fine:

CleanShot 2022-07-04 at 23 28 13@2x

@mfridman mfridman merged commit e2da1ad into main Jul 5, 2022
@mfridman mfridman deleted the GH-71 branch July 5, 2022 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant