-
-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump to phpstan-drupal 0.12 #119
Conversation
🤔 this is new and not happening in phpstan-drupal
|
The new packaging breaks how drupal-check was running PHPStan. But maybe this is OK and we don't need a custom runner any longer. |
So we lost the custom error handler that prevented phpstan from dying, \DrupalCheck\DrupalCheckErrorHandler. That prevented crashes like
|
This isn't being caught either anymore. I wonder if we can just include the prefixed namespace since PHPStan is embedded. But that wouldn't work for non phar builds unless this shipped as a phar always like PHPStan and Rector |
141c8cd
to
4890fd0
Compare
88db5d4
to
22b4781
Compare
Remaining items
|
No description provided.