Cast: Fix for VC #2
Conversation
With string input, the "stdin" entry would get sorted away from the start of the array. This lead to a strange bug since we skip the first item when copying that information back to the implementer.
Define a custom function named '@warn' to get called when the corresponding statement is found in sass code. Use a function named '*' as a fallback, if the requested function is not found. The original function name will be the first argument (along with the rest of the original arguments).
User will need to create a copy if the memory is static! Otherwise he can pass the string to libsass and we will take care to free the memory when the context is destroyed.
Allows to port sassc easier to the new API! Additionally fixes some 'const char*' missuses!
This allows to query include files before the compile step!
We do not want to force implementers to need json parsing functionality, just to get the extended error information.
We may not know how long these strings will live, therefore we pay to price to create copies of them. We only let users pass potentially very big char arrays directly to libsass!
|
Separately, I have found a little inconsistency with JSON errors column number. Consider the following code: $test: (
one: 1,
two: 2,
;Given line and comlum numbers are But, it returns: {
"status": 1,
"path": "C:/temp/foo.scss",
"line": 3,
"column": 9,
"message": "invalid syntax"
}Also, the JSON has eight-space indentation, can you please reduce it to four? Thanks! |
|
In the same example code, I made an error on -$test: (
one: 1,
two: 2,
);It returns: {
"status": 1,
"path": "C:/temp/foo.scss",
"line": 1,
"column": 1,
"message": "invalid top-level expression"
}The index, in fact, starts with 1. I have updated the above comment accordingly. Question: Are we using the same 1-based indexes with source-maps as well? |
|
Side note: can you please change |
mgreter
force-pushed
the
api/c-interface
branch
from
57a0158 to
c7b4c34
Compare
|
The error position is reported as previously. I merely just pass the internal values through. |
|
Cherrypicked your commit into my branch! |
|
That is awesome; less noisy and sleeker! Thanks. 😄 👍 For error position, there is this related issue, that the |
|
The Backtrace is IMO added in |
As described at: sass#635 (comment).