-
Notifications
You must be signed in to change notification settings - Fork 808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
_win32sysloader now uses the same LoadLibrary flags as Python itself … #1794
Conversation
oops - so something is going wrong on CI that I can't reproduce locally - I'll get back to this later. |
f6e0cc8
to
aa8f482
Compare
So I fixed CI but I'm not quite sure how it worked in the first place: on CI, we run So I still need to better understand this, but in the meantime I'd love you hear of experiences using the artifacts. |
(eg, if you go to the test run at https://github.com/mhammond/pywin32/actions/runs/1447472934, you can find an "artifacts" link which will download a .zip with all the .whl files) |
@mhammond much thanks, I tested |
@mhammond will this be pushed to pypi soon? |
@mhammond sorry for the delay - I tested it and it appears to solve my issue. A conflicting DLL in my PATH is no longer being found and loaded. Thank you! |
aa8f482
to
18f7cc9
Compare
* Tweaks to how DLLs are loaded and our installation found, which should | ||
improve virtualenv support and version mismatch issues (#1787, #1794) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great PR as it prevents loading DLLs from the current directory which is considered insecure.
Besides "improve virtualenv support and version mismatch issues", using LOAD_LIBRARY_SEARCH_DEFAULT_DIRS
and LOAD_LIBRARY_SEARCH_DLL_LOAD_DIR
also causes other changes regarding how DLLs are loaded, including "DLLs in the current directory are no longer loaded". It will be better if the change log can explain how "tweaks" are made. 😉
…(fixes #1787)
@davidkhess and @tshemeng, it would be great if you could try the artifacts from this PR and see if it addresses your problems.