Fix StremThru response handling

[MunifTanjim]

StremThru response are in shape of either { data: { ... } } or { error: { ... } }.

._make_request method is already returning .data and raising error otherwise. So no need to access ["data"] again on the return value of ._make_request method.

Summary by CodeRabbit

• New Features

  • Enhanced error handling with clearer messages for better user understanding.
  • Updated methods now return more comprehensive response data, improving user access to information.

• Bug Fixes

  • Streamlined response validation process to reduce potential errors.

[coderabbitai]

Walkthrough

The changes in the pull request focus on the StremThru class within the streaming_providers/stremthru/client.py file. Key modifications include the removal of the _validate_error_response method, with its functionality incorporated into the _make_request method, which now raises a ProviderException with enhanced error messages. Additionally, several methods have been updated to return more comprehensive data, including the entire response instead of just specific fields, streamlining error handling and improving data accessibility.

Changes

File Path	Change Summary
streaming_providers/stremthru/client.py	- Removed _validate_error_response method; integrated into _make_request method. - Updated _make_request to raise ProviderException with detailed error messages. - Modified add_magnet_link to return entire response_data. - Updated get_torrent_info to return complete response instead of just "data". - Simplified get_available_torrent by removing validation call and accessing "items" directly.

Poem

In the fields where data flows,
A rabbit hops where clarity grows.
With messages bright and errors tamed,
Our StremThru's now more easily named.
So let’s dance in the code so fine,
For every change, a reason to shine! 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between d668be0 and 55d24bd.

📒 Files selected for processing (1)

• streaming_providers/stremthru/client.py (2 hunks)

🔇 Additional comments (4)

streaming_providers/stremthru/client.py (4)

65-66: LGTM! Improved error message handling.

The use of str() ensures safe string conversion of error messages, making the error handling more robust.

---

74-74: LGTM! Removed redundant data access.

The change correctly relies on ._make_request to handle the data extraction, eliminating unnecessary code.

---

81-81: LGTM! Consistent with the response handling improvements.

The change maintains consistency with the new response handling pattern.

---

90-90: Verify the response structure for robustness.

Direct access to available_torrents["items"] assumes this key will always exist. While this might be guaranteed by the API, consider adding a safety check or verifying the API contract.

Consider adding a safety check:

-        for torrent in available_torrents["items"]:
+        items = available_torrents.get("items", [])
+        for torrent in items:

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.