Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: build project before publish to NPM #57

Merged
merged 2 commits into from
Feb 25, 2024
Merged

ci: build project before publish to NPM #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a193d70
ci: build project before publish
mheob Feb 25, 2024
627ffe8
chore(deps): update dependencies
mheob Feb 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,9 @@ jobs:
- name: Install Dependencies
run: pnpm install --frozen-lockfile

- name: Build the project
run: pnpm build

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Release binary step uses npm publish to publish the package. Given that the workflow uses PNPM for dependency management and build processes, consider using pnpm publish instead of npm publish for consistency and to leverage any PNPM-specific features or optimizations during the publication process. This change could potentially enhance the reliability and efficiency of the release workflow.

- run: npm publish
+ run: pnpm publish
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change

- name: Release binary
run: npm publish
env:
Expand Down
6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,13 +56,13 @@
"@mheob/eslint-config": "^5.2.0",
"@mheob/prettier-config": "^3.2.0",
"@mheob/tsconfig": "^2.0.0",
"@types/node": "^20.11.19",
"@types/node": "^20.11.20",
"@vitest/coverage-v8": "^1.3.1",
"commitizen": "^4.3.0",
"concurrently": "^8.2.2",
"cz-git": "^1.8.0",
"eslint": "^8.56.0",
"husky": "^9.0.0",
"eslint": "^8.57.0",
"husky": "^9.0.11",
"lint-staged": "^15.2.2",
"prettier": "^3.2.5",
"rimraf": "^5.0.5",
Expand Down
Loading