health based check before polling vm #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhewedy
requested changes
Apr 5, 2024
mhewedy
reviewed
Apr 8, 2024
| @@ -22,7 +22,7 @@ type Hypervisor interface { | |||
|
|
|||
| Modify(vmName string, cpus int, mem int) error | |||
|
|
|||
| HealthCheck(vmName, property string) (*string, error) | |||
| HealthCheck(vmName string) (*string, error) | |||
There was a problem hiding this comment.
Why return *string? the string you assert on in the ip.go ("UP") is VirtualBox specific.
better to make it general. so it is either pass (return nil error) or return an error
There was a problem hiding this comment.
agreed making this return boolean instead of string
Merged
mhewedy
reviewed
Apr 8, 2024
|
|
||
| // Wait for health status to be "Up" for up to 5 minutes | ||
| timeout := time.After(5 * time.Minute) | ||
| for *health != "Up" { |
There was a problem hiding this comment.
part of this logic is internal to VirtualBox (checking the "up" string), other part (the loop and the timeout thing) is general to all Healthchecks
I'll accept this PR and will open another PR to illustrate what I mean here ...
|
I'll accept this PR and will open another PR to let you know what I mean... will make you a reviewer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #51