Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use explicit winnr with O mapping #45

Closed
wants to merge 1 commit into from

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Apr 9, 2016

With autocommands etc you might not end up in the previous/qf window
otherwise.

With autocommands etc you might not end up in the previous/qf window
otherwise.
@blueyed
Copy link
Contributor Author

blueyed commented Apr 9, 2016

This could also make use of the method in #46, but is more simple this way.
It will trivially conflict with #44.

@mhinz
Copy link
Owner

mhinz commented Jun 2, 2016

Thanks, merged!

@mhinz mhinz closed this Jun 2, 2016
@@ -455,6 +455,7 @@ function! s:finish_up(flags) abort
nnoremap <silent><buffer> <cr> <cr>zv
nnoremap <silent><buffer> o <cr>zv
nnoremap <silent><buffer> O <cr>zv<c-w>p
nnoremap <silent><buffer> O :let w=winnr()<cr><cr>zv:exec w 'wincmd p'<cr>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, forgot to remove the original mapping: #49.

Copy link
Owner

@mhinz mhinz Jun 2, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

D'oh, I saw it while I read the diff, but forgot to remove it myself..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably because you got distracted by renaming the var?! ;)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hah, well, the more important thing was adding the unlet because global var and all that. :-P

@blueyed blueyed deleted the more-robust-O branch June 2, 2016 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants