expose Papa.getScriptPath for overriding #126
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids the security restrictions on web workers over file://.
This also provides a Papa.getFakeScriptPath, which is awesome but broken in IE. :(
|
Oh dang, this has a lot of overlap with #120 . |
|
Ah. Yeah, I think I see where you're going with this. We'll probably use something more like what @edg2s comes up with (his PR is nearly complete)... feel free to comment on it if you'd like. |
|
Makes sense. Stupid IE. :-\ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also provides a Papa.getFakeScriptPath, which is awesome but broken in IE. :(
I understand if you want me to remove getFakeScriptPath entirely to avoid confusing people. It's a pity, though, since it allows for concatenating the library into a bundle.