Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed cursor when duplicated header #997

Merged
merged 1 commit into from
Apr 13, 2023

Conversation

jsakaicribl
Copy link
Contributor

When processing duplicate headers with header auto, the position of meta.cursor will be returned as the position of cursor including renamed headers such as _. But it's different from the cursor of the actual file. So set the cursor to the length of the original header.

papaparse.js Outdated Show resolved Hide resolved
papaparse.js Outdated Show resolved Hide resolved
tests/test-cases.js Outdated Show resolved Hide resolved
When processing duplicate headers with header auto, the position of
meta.cursor will be returned as the position of cursor including renamed
headers such as _<number>. But it's different from the cursor of the actual
file. So set the cursor to the length of the original header.
@jsakaicribl jsakaicribl force-pushed the fix-cursor-for-duplicated-header branch from b3da7d3 to 8f03fed Compare April 13, 2023 07:39
@pokoli pokoli merged commit b536555 into mholt:master Apr 13, 2023
@pokoli
Copy link
Collaborator

pokoli commented Apr 13, 2023

Your patch is merged, thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants