Some Mode field can be strings #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yupmin could you check if it's look good to you? |
|
|
||
| return $mode; | ||
| return new Mode($rateMode[0], $rateMode[1]); |
There was a problem hiding this comment.
@GrahamCampbell what is the issue?
There was a problem hiding this comment.
there should be exactly one space following return, not two
mhor
force-pushed
the
fix_27
branch
2 times, most recently
from
4787f7f to
b6dd4e5
Compare
|
@GrahamCampbell thanks for review |
| * | ||
| * @return Mode | ||
| */ | ||
| public function create($rateMode) | ||
| { | ||
| $rateMode = (array) $rateMode; | ||
| if (!isset($rateMode[1])) { |
There was a problem hiding this comment.
would be cleaner to leave a newline before this if statement
|
@mhor Yes. I Tested this. It works well. |
|
@yupmin tag as 1.4.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #27