architecture improvement + unit tests + cs fix #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhor
force-pushed
the
unit_test
branch
5 times, most recently
from
13da6cd to
973882d
Compare
mhor
changed the title
mhor
added a commit
that referenced
this pull request
Dec 11, 2014
architecture improvement / unit tests / cs fix
|
Changes Unknown when pulling 0e0511f on unit_test into * on master*. |
padre
added a commit
to padre/php-mediainfo
that referenced
this pull request
Jun 10, 2022
In a video, the following instruction generates an exception: $mediaInfoContainer = $mediaInfo->getInfo($url); The reason for this is that the Mode class receives an (empty) array as parameter. This is the log: Mhor\MediaInfo\Attribute\Mode::__construct(): Argument mhor#2 ($fullName) must be of type string, array given, called in /var/app/current/vendor/mhor/php-mediainfo/src/Checker/ModeChecker.php on line 22 {"userId":13,"exception":"[object] (TypeError(code: 0): Mhor\\MediaInfo\\Attribute\\Mode::__construct(): Argument mhor#2 ($fullName) must be of type string, array given, called in /var/app/current/vendor/mhor/php-mediainfo/src/Checker/ModeChecker.php on line 22 at /var/app/current/vendor/mhor/php-mediainfo/src/Attribute/Mode.php:25) [stacktrace] #0 /var/app/current/vendor/mhor/php-mediainfo/src/Checker/ModeChecker.php(22): Mhor\\MediaInfo\\Attribute\\Mode->__construct(' 0', Array) mhor#1 /var/app/current/vendor/mhor/php-mediainfo/src/Factory/AttributeFactory.php(27): Mhor\\MediaInfo\\Checker\\ModeChecker->create(Array) mhor#2 /var/app/current/vendor/mhor/php-mediainfo/src/Builder/MediaInfoContainerBuilder.php(71): Mhor\\MediaInfo\\Factory\\AttributeFactory::create('writing_library', Array) mhor#3 /var/app/current/vendor/mhor/php-mediainfo/src/Builder/MediaInfoContainerBuilder.php(53): Mhor\\MediaInfo\\Builder\\MediaInfoContainerBuilder->addAttributes(Object(Mhor\\MediaInfo\\Type\\Audio), Array) mhor#4 /var/app/current/vendor/mhor/php-mediainfo/src/Parser/MediaInfoOutputParser.php(49): Mhor\\MediaInfo\\Builder\\MediaInfoContainerBuilder->addTrackType('Audio', Array) mhor#5 /var/app/current/vendor/mhor/php-mediainfo/src/MediaInfo.php(44): Mhor\\MediaInfo\\Parser\\MediaInfoOutputParser->getMediaInfoContainer(false) mhor#6 /var/app/current/app/Http/Controllers/Backend/MediaController.php(103): Mhor\\MediaInfo\\MediaInfo->getInfo('https://d3q5g9h...')
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.