Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mediainfocontainer-dump-xml #52

Merged
merged 22 commits into from
May 6, 2016
Merged

mediainfocontainer-dump-xml #52

merged 22 commits into from
May 6, 2016

Conversation

javiertrejo
Copy link
Contributor

Hi @mhor,

I added support to dump MediaInfoContainer or any Type to XML.

Unit Test Added.

Regards,

unknown and others added 19 commits April 29, 2016 22:25
added globally support to dump the "MediaInfoContainer" into json and…
c56d790 
… array
readme.md updated
81445da
composer.json > PHP Required version updated
151569e
added .gitignore
829a98f
composer.lock removed
dcfdc86
composer.phar removed
109b498
vendor directory removed
6a1a6b1
Merge branch 'feature/mediainfocontainer-dump' of https://github.com/…
e32ae2d 
…javiertrejo/php-mediainfo into feature/mediainfocontainer-dump
CI fix
d7a913e
readme.md restores
fc61320
Added unit tests
a9c12c5
Added unit test without require mediainfo
40e06bb
Removed 5.3.x test for CI
a78d06e
added support to XML Dump
83b646a
continuous integration general fixs
789d88a
coveralls fixs
6928a2d
Merge branch 'feature/mediainfocontainer-dump' into develop
5737242
@mhor
[Travis] disable XDebug
d6e4d76
@mhor
Merge pull request #53 from mhor/travis-disable-xdebug
f908b5f 
[Travis] disable XDebug
@javiertrejo
Copy link
Contributor Author

Hi @mhor, you have time to see this request?

Regards,

@mhor
Copy link
Owner

mhor commented May 5, 2016

Hi @javiertrejo, could you:

unknown added 2 commits May 6, 2016 00:16
Merge branch 'develop'
f6acaa8 
# Conflicts:
#	src/Type/AbstractType.php
#	test/Container/MediaInfoContainerTest.php
readme.md updates with XML dump example
567153c
@javiertrejo javiertrejo changed the title Develop mediainfocontainer-dump-xml May 6, 2016
@javiertrejo
Copy link
Contributor Author

Hi @mhor,

The requested changes has been applied. Sorry for my mistake, i'm a newbie with forking 3rd party projects and contributing.
To dump to YAML it's necesary use PECL/YAML extension. This is not a common part of PHP installations but is possible to do.
Considers useful and necessary to have the option to dump to YAML?
The next week i will be applied this project in a production environment. If any bug will be detected; i will send to you a new pull request with the fixs.

Regards,

@mhor
Copy link
Owner

mhor commented May 6, 2016 •
edited
Loading

@javiertrejo I didn't know if dumping to YAML is useful. To dump yaml IMO the easiest way is to use of YAML symfony component

Thanks for pull request I will merge it!

@mhor mhor merged commit 38f4f81 into mhor:master May 6, 2016
@mhor
Copy link
Owner

mhor commented May 6, 2016

@javiertrejo merged and released as 2.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@javiertrejo @mhor