Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider replacing validators.url #18

Closed
micahcochran opened this issue Jun 9, 2021 · 0 comments
Closed

Consider replacing validators.url #18

micahcochran opened this issue Jun 9, 2021 · 0 comments

Comments

@micahcochran
Copy link
Owner

Considering dropping validators library as a requirement. I have reservations about using the libraries validators or validators-collection. The lengths that those libraries go to are much more than should be for validators.get. I think using a simple test such as string.startswith("http://", "https://") would be more appropriate.

Also, adding a timeout for requests.get() call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant