Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Micah,
Thanks again for your library!
This PR aims to solve a parsing issue when time are not set.
Drinks at allrecipes.com tend to not have a cooking time (
cookTime
) set.In their schema, the value is set to null:
In their webpage, the
null
value is used to hide fields. A couple of examples are:https://www.allrecipes.com/recipe/237874/simple-moscow-mule/
https://www.allrecipes.com/recipe/272987/watermelon-mojitos/
Here, we add a check for
None
and remove the key from the recipe dictionary.I've also added a unit test with one of the above recipe checking that the key is correctly removed.
Thanks!
Cyril