Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for 4.1 #124

Merged
merged 3 commits into from
Aug 18, 2024
Merged

Added support for 4.1 #124

merged 3 commits into from
Aug 18, 2024

Conversation

OctavoPE
Copy link
Contributor

This change actually continues rig support for previous versions of Blender/Goo as well. A note is made that the new shader only supports 4.1 anyway.

Copy link
Owner

@michael-gh1 michael-gh1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Approved, but also had a question

@michael-gh1 michael-gh1 merged commit b9dd7ce into michael-gh1:main Aug 18, 2024
@OctavoPE
Copy link
Contributor Author

Check this out, this is why we needed the change. https://projects.blender.org/blender/blender/issues/124891
Our original loop loops through the collection as we're actively removing from it. The blender developer that responded confirmed that was unintended behavior. In previous version of Blender, we got away with it scot-free, but with 4.1 it crashes. As they pointed out, a .clear() method is ideal but we don't have that yet lmao. The solution was this response here: https://projects.blender.org/blender/blender/issues/124891#issuecomment-1245473
Not sure why the OP fought with the Blender dev after he got his fix but yeah lol.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants