Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: README Sprite example #110

Closed

Conversation

coolryanc
Copy link

Hi,

Looks like the method of PIXI.Sprite only has from now.
Ref: http://pixijs.download/release/docs/PIXI.Sprite.html#.from

@codecov
Copy link

codecov bot commented May 28, 2019

Codecov Report

Merging #110 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #110   +/-   ##
=======================================
  Coverage   95.67%   95.67%           
=======================================
  Files          11       11           
  Lines         231      231           
=======================================
  Hits          221      221           
  Misses         10       10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d1fa7c...af6a7c6. Read the comment docs.

@michalochman
Copy link
Owner

michalochman commented May 28, 2019

Hi @ryanc1993, it's a Texture method, not Sprite, and it is only true for PixiJS v5.

This library is compatible with PixiJS v4 as well, but I will merge this as we probably need to keep documentation updated with the newest versions of dependencies. Can you update all instances of this?

@michalochman michalochman changed the title fix: README Stripe example fix: README Sprite example May 28, 2019
@coolryanc
Copy link
Author

Okay, I will try other examples at README document and help update it. 👍

@michalochman
Copy link
Owner

Done comprehensively in #123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants